[SPARK-32487][CORE] Remove j.w.r.NotFoundException from import in [Stages|OneApplication]Resource
#29293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` in StagesResource/OneApplicationResource
dongjoon-hyun
changed the title
import in StagesResource/OneApplicationResourceimport in [Stages|OneApplication]Resource
Member
Author
|
cc @srowen |
srowen
reviewed
Jul 29, 2020
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems fine if this is the easy way to fix the conflict. You could also explicitly import for j.w.r if there aren't a lot of classes.
Member
Author
|
Yes. This is the easiest and shortest one~ |
|
Test build #126787 has finished for PR 29293 at commit
|
Member
Author
|
Thanks. Merged to master. |
Member
|
Nice, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
java.ws.rs.NotFoundExceptionfrom two problematicimportstatements. All the other use cases are correct.Why are the changes needed?
In
StagesResourceandOneApplicationResource, there exist twoNotFoundExceptions.To use
org.apache.spark.status.api.v1.NotFoundExceptioncorrectly, we should not importjava.ws.rs.NotFoundException. This causes UT failures in Scala 2.13 environment.Does this PR introduce any user-facing change?
No.
How was this patch tested?
BEFORE
AFTER