Skip to content

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Add training summary to MultilayerPerceptronClassificationModel...

Why are the changes needed?

so that user can get the training process status, such as loss value of each iteration and total iteration number.

Does this PR introduce any user-facing change?

Yes
MultilayerPerceptronClassificationModel.summary
MultilayerPerceptronClassificationModel.evaluate

How was this patch tested?

new tests

@SparkQA
Copy link

SparkQA commented Jul 26, 2020

Test build #126588 has finished for PR 29250 at commit 0a570ad.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class MultilayerPerceptronClassificationSummary(_ClassificationSummary):
  • class MultilayerPerceptronClassificationTrainingSummary(MultilayerPerceptronClassificationSummary,

@SparkQA
Copy link

SparkQA commented Jul 27, 2020

Test build #126589 has finished for PR 29250 at commit 0d240a4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

'NaiveBayes', 'NaiveBayesModel',
'MultilayerPerceptronClassifier', 'MultilayerPerceptronClassificationModel',
'MultilayerPerceptronClassificationSummary',
'MultilayerPerceptronClassificationTrainingSummary',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huaxingao, are these going to be documented? Might be good to list at pyspark.ml.rst too if so. The documentation PR (#29188) was merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon updated pyspark.ml.rst. Thanks!

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally OK to me

@SparkQA
Copy link

SparkQA commented Jul 27, 2020

Test build #126663 has finished for PR 29250 at commit 328797c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in 40e6a5b Jul 29, 2020
@srowen
Copy link
Member

srowen commented Jul 29, 2020

Merged to master

@huaxingao
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants