[SPARK-4075] [Deploy] Jar url validation is not enough for Jar file #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 that's much more flexible and likely to catch syntax errors early. |
|
Test build #22134 has finished for PR 2925 at commit
|
Contributor
|
Yeah LGTM I'm merging this into master and 1.1 thanks. |
Contributor
There was a problem hiding this comment.
space before should, but I'll fix this when I merge
asfgit
pushed a commit
that referenced
this pull request
Oct 24, 2014
In deploy.ClientArguments.isValidJarUrl, the url is checked as follows.
def isValidJarUrl(s: String): Boolean = s.matches("(.+):(.+)jar")
So, it allows like 'hdfs:file.jar' (no authority).
Author: Kousuke Saruta <[email protected]>
Closes #2925 from sarutak/uri-syntax-check-improvement and squashes the following commits:
cf06173 [Kousuke Saruta] Improved URI syntax checking
(cherry picked from commit 098f83c)
Signed-off-by: Andrew Or <[email protected]>
Contributor
|
It appears that this commit caused a serious regression in master and the current 1.1.1. release candidate: https://issues.apache.org/jira/browse/SPARK-4434 |
Member
Author
|
Ah, O.K. I'll revert this for master and 1.1. |
Contributor
|
Here I'll do it myself. Thanks for the PR |
sarutak
added a commit
to sarutak/spark
that referenced
this pull request
Nov 18, 2014
In deploy.ClientArguments.isValidJarUrl, the url is checked as follows.
def isValidJarUrl(s: String): Boolean = s.matches("(.+):(.+)jar")
So, it allows like 'hdfs:file.jar' (no authority).
Author: Kousuke Saruta <[email protected]>
Closes apache#2925 from sarutak/uri-syntax-check-improvement and squashes the following commits:
cf06173 [Kousuke Saruta] Improved URI syntax checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deploy.ClientArguments.isValidJarUrl, the url is checked as follows.
So, it allows like 'hdfs:file.jar' (no authority).