Skip to content

[SPARK-32234][FOLLOWUP][SQL]Update the description of utility method #29232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SaurabhChawla100 wants to merge 4 commits into from
Closed

[SPARK-32234][FOLLOWUP][SQL]Update the description of utility method #29232

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
452c3dd
update the decription helper method
SaurabhChawla100 Jul 25, 2020
0f411b7
update the decription helper method
SaurabhChawla100 Jul 25, 2020
80ccedd
add the code change to update prunned col in the desc
SaurabhChawla100 Jul 25, 2020
54bba19
update the description of the method
SaurabhChawla100 Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,19 @@ object OrcUtils extends Logging {
}

/**
* @return Returns the result schema string based on the canPruneCols flag.
* resultSchemaString will be created using resultsSchema in case of
* canPruneCols is true and for canPruneCols as false value
* resultSchemaString will be created using the actual dataSchema.
* This method returns the result schema as string based on the canPruneCols flag.

@HyukjinKwon HyukjinKwon Jul 27, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just write as:

Returns the result schema to read from ORC file. In addition, It sets the schema string to 'orc.mapred.input.schema' so ORC readers can use later.

and inline the details about parameters into the parameter descriptions below.

@SaurabhChawla100 SaurabhChawla100 Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks fine. Will update as suggested

* resultSchemaString will be created using pruned col in case of
* canPruneCols is true and for canPruneCols as false value
* resultSchemaString will be created using the actual dataSchema.
* Also as the part of this method update the MAPRED_INPUT_SCHEMA

@cloud-fan cloud-fan Jul 27, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the MAPRED_INPUT_SCHEMA -> updates the MAPRED_INPUT_SCHEMA in the given 'conf'.

@SaurabhChawla100 SaurabhChawla100 Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment as suggested by @HyukjinKwon

*
* @param canPruneCols Flag to decide whether pruned cols schema is send to resultSchema
* or send the entire dataSchema to resultSchema.
* @param dataSchema Schema of the orc files.
* @param resultSchema Result data schema created from the query.
* @param partitionSchema Schema of partitions.
* @param conf Hadoop Configuration
* @return Returns the result schema as string
*/
def orcResultSchemaString(
canPruneCols: Boolean,
Expand Down