-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29802][BUILD] Use python3 in build scripts #29151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fokkodriesprong@Fan spark % grep -R "env python" .
./python/pyspark/version.py:#!/usr/bin/env python3
./python/pyspark/find_spark_home.py:#!/usr/bin/env python3
./python/setup.py:#!/usr/bin/env python3
./python/run-tests.py:#!/usr/bin/env python3
./dev/create-release/releaseutils.py:#!/usr/bin/env python3
./dev/create-release/generate-contributors.py:#!/usr/bin/env python3
./dev/create-release/translate-contributors.py:#!/usr/bin/env python3
./dev/github_jira_sync.py:#!/usr/bin/env python3
./dev/merge_spark_pr.py:#!/usr/bin/env python3
./dev/run-tests-jenkins.py:#!/usr/bin/env python3
./dev/run-tests.py:#!/usr/bin/env python3
|
LGTM, just ran into needing this ~30 minutes ago on one of my laptops :) |
|
Test build #126071 has finished for PR 29151 at commit
|
|
Jenkins retest this please |
|
Test build #126079 has finished for PR 29151 at commit
|
|
The pip packaging failure is interesting. Let me know if you want me to
take a deeper look at our packaging tests.
On Fri, Jul 17, 2020 at 7:00 PM UCB AMPLab ***@***.***> wrote:
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126079/
Test FAILed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#29151 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOT5PGIN2XAW77ULAR3DDR4D64HANCNFSM4O6ZS5KQ>
.
--
Cell : 425-233-8271
|
HeartSaVioR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This should be helpful when you encounter the issue on merging PR who has non-ascii char in their name/email. Possibly also for PR title/description as well.
|
Hm, yeah that's a weird failure. I'm guessing it's related but not sure why. @holdenk @shaneknapp @HyukjinKwon do you know why that might happen? |
|
Give the following log, it seems to be related to |
|
Merged to master. |
|
With the test results from Jenkins and GitHub Actions, seems all tests pass. |
What changes were proposed in this pull request?
Use
/usr/bin/env python3consistently instead of/usr/bin/env pythonin build scripts, to reliably select Python 3.Why are the changes needed?
Scripts no longer work with Python 2.
Does this PR introduce any user-facing change?
No, should be all build system changes.
How was this patch tested?
Existing tests / NA