Skip to content

[SPARK-32253][INFRA] Show errors only for the sbt tests of github actions #29133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 5 commits into from
Closed

[SPARK-32253][INFRA] Show errors only for the sbt tests of github actions #29133

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bcfbb1
show error only
gengliangwang Jul 16, 2020
60db1af
fix flag
gengliangwang Jul 16, 2020
663e5a7
fix
gengliangwang Jul 16, 2020
3590262
update comment
gengliangwang Jul 16, 2020
2d39b8e
add comments and remove option 'S'
gengliangwang Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dev/run-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,9 @@ def main():
# If we're running the tests in Github Actions, attempt to detect and test
# only the affected modules.
if test_env == "github_actions":
# Set the log level of sbt as ERROR to make the output more readable.
if build_tool == "sbt":
extra_profiles.append("--error")
if os.environ["GITHUB_BASE_REF"] != "":
# Pull requests
changed_files = identify_changed_files_from_git_commits(
Expand Down
5 changes: 5 additions & 0 deletions project/SparkBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,11 @@ object TestSettings {
}.getOrElse(Nil): _*),
// Show full stack trace and duration in test cases.
testOptions in Test += Tests.Argument("-oDF"),
// Show only the failed test cases in github action to make the log more readable.
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest,
sys.env.get("GITHUB_ACTIONS").map { _ =>
Seq("-eNCXEHLOPQMDSF")

@gengliangwang gengliangwang Jul 16, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check https://www.scalatest.org/user_guide/using_the_runner for the options here.

@dongjoon-hyun dongjoon-hyun Jul 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you explicitly enabled all available standard error options except W and U. If then, could you describe the reason why you choose some and exclude those two, please?

W - without color
U - unformatted mode

@dongjoon-hyun dongjoon-hyun Jul 17, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you add the link into the comment at below line 1030 because this is non-trivial?

@gengliangwang gengliangwang Jul 17, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we drop all the following events:

N - drop TestStarting events
C - drop TestSucceeded events
X - drop TestIgnored events
E - drop TestPending events
H - drop SuiteStarting events
L - drop SuiteCompleted events
O - drop InfoProvided events
P - drop ScopeOpened events
Q - drop ScopeClosed events
R - drop ScopePending events
M - drop MarkupProvided events

and enable the following two mode:

D - show all durations
F - show full stack traces

@gengliangwang gengliangwang Jul 17, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following two modes will make the readability worse

W - without color
U - unformatted mode

@dongjoon-hyun dongjoon-hyun Jul 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put that explanation into the PR description, please? PR description will become a permanent commit log . So, it will help other people to understand your decision. Thanks, @gengliangwang .

@gengliangwang gengliangwang Jul 17, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun Sure, I have updated the pr description.

}.getOrElse(Nil): _*),
testOptions in Test += Tests.Argument(TestFrameworks.JUnit, "-v", "-a"),
// Required to detect Junit tests for each project, see also https://github.com/sbt/junit-interface/issues/35
crossPaths := false,
Expand Down