Skip to content

[SPARK-32329][TESTS] Rename HADOOP2_MODULE_PROFILES to HADOOP_MODULE_PROFILES #29128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
williamhyun wants to merge 1 commit into from
Closed

[SPARK-32329][TESTS] Rename HADOOP2_MODULE_PROFILES to HADOOP_MODULE_PROFILES #29128

williamhyun wants to merge 1 commit into from

Conversation

@williamhyun
Copy link
Member

@williamhyun williamhyun commented Jul 16, 2020 •
edited
Loading

What changes were proposed in this pull request?

This PR aims to rename HADOOP2_MODULE_PROFILES to HADOOP_MODULE_PROFILES because Hadoop 3 is now the default.

Why are the changes needed?

Hadoop 3 is now the default.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GitHub Action dependency test.

@williamhyun williamhyun changed the title [SPARK-XXX][TESTS] Rename HADOOP2_MODULE_PROFILES to HADOOP_MODULE_PROFILES [SPARK-32329][TESTS] Rename HADOOP2_MODULE_PROFILES to HADOOP_MODULE_PROFILES Jul 16, 2020
@srowen
Copy link
Member

srowen commented Jul 16, 2020

Jenkins test this please

srowen
srowen approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK pending tests

@SparkQA
Copy link

SparkQA commented Jul 16, 2020

Test build #125981 has finished for PR 29128 at commit 5f7fe1b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 16, 2020

I'll run tests again just for run, but this cannot be a related failure; this script isn't even used in what it tests.

@srowen
Copy link
Member

srowen commented Jul 16, 2020

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Jul 16, 2020

Test build #125994 has finished for PR 29128 at commit 5f7fe1b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 17, 2020

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Jul 17, 2020

Test build #126017 has finished for PR 29128 at commit 5f7fe1b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 17, 2020

Merged to master

@srowen srowen closed this in 5daf244 Jul 17, 2020
@williamhyun
Copy link
Member Author

williamhyun commented Jul 17, 2020

Thank you for reviewing and merging, @srowen and @HyukjinKwon

@williamhyun williamhyun deleted the williamhyun-patch-3 branch July 17, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

BUILD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@williamhyun @srowen @SparkQA @HyukjinKwon