[SPARK-32283][CORE] Kryo should support multiple user registrators #29123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #125880 has finished for PR 29123 at commit
|
Contributor
Author
|
retest this please |
Contributor
Author
|
Retest this please |
|
Test build #125928 has finished for PR 29123 at commit
|
Contributor
Author
Contributor
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Jul 28, 2020
| val KRYO_USER_REGISTRATORS = ConfigBuilder("spark.kryo.registrator") | ||
| .version("0.5.0") | ||
| .stringConf | ||
| .createOptional |
Contributor
There was a problem hiding this comment.
do you know which commit broke it?
Contributor
Author
There was a problem hiding this comment.
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jul 29, 2020
### What changes were proposed in this pull request? `spark.kryo.registrator` in 3.0 has a regression problem. From [SPARK-12080](https://issues.apache.org/jira/browse/SPARK-12080), it supports multiple user registrators by ```scala private val userRegistrators = conf.get("spark.kryo.registrator", "") .split(',').map(_.trim) .filter(!_.isEmpty) ``` But it donsn't work in 3.0. Fix it by `toSequence` in `Kryo.scala` ### Why are the changes needed? In previous Spark version (2.x), it supported multiple user registrators by ```scala private val userRegistrators = conf.get("spark.kryo.registrator", "") .split(',').map(_.trim) .filter(!_.isEmpty) ``` But it doesn't work in 3.0. It's should be a regression. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existed unit tests. Closes #29123 from LantaoJin/SPARK-32283. Authored-by: LantaoJin <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 26e6574) Signed-off-by: Wenchen Fan <[email protected]>
Member
|
+1, late LGTM. Thank you, @LantaoJin and @cloud-fan . cc @HeartSaVioR and @srowen |
Contributor
|
Nice find and thanks for fixing this! I have no idea why I took different way to deal with KRYO_USER_REGISTRATORS and KRYO_CLASSES_TO_REGISTER... I guess it was just a mistake. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
spark.kryo.registratorin 3.0 has a regression problem. From SPARK-12080, it supports multiple user registrators byBut it donsn't work in 3.0. Fix it by
toSequenceinKryo.scalaWhy are the changes needed?
In previous Spark version (2.x), it supported multiple user registrators by
But it doesn't work in 3.0. It's should be a regression.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existed unit tests.