Skip to content

[SPARK-32094][PYTHON] Update cloudpickle to v1.5.0 #29114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-32094][PYTHON] Update cloudpickle to v1.5.0 #29114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ BSD 3-Clause
------------

python/lib/py4j-*-src.zip
python/pyspark/cloudpickle.py
python/pyspark/cloudpickle/*.py
Copy link
Member

@viirya viirya Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is it only for cloudpickle.py and cloudpickle_fast.py?

Copy link
Member Author

@HyukjinKwon HyukjinKwon Jul 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It catches the directory python/pyspark/cloudpickle/ :-).

Copy link
Member

@viirya viirya Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this use for license declaration?

Copy link
Member Author

@HyukjinKwon HyukjinKwon Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh

Copy link
Member

@viirya viirya Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not big deal to have BSD 3 for other two files. :)

Copy link
Member Author

@HyukjinKwon HyukjinKwon Jul 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we ported __init__.py and compat.py here too and it includes all.

Looks like their license wasn't changed from the very first release (https://github.com/cloudpipe/cloudpickle/blob/master/LICENSE). I guess it might be fine..

python/pyspark/join.py
core/src/main/resources/org/apache/spark/ui/static/d3.min.js

Expand Down
4 changes: 2 additions & 2 deletions dev/.rat-excludes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ jsonFormatter.min.js
.*json
.*data
.*log
pyspark-coverage-site/
cloudpickle.py
pyspark-coverage-site/*
cloudpickle/*
heapq3.py
join.py
SparkExprTyper.scala
Expand Down
2 changes: 1 addition & 1 deletion dev/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
[pycodestyle]
ignore=E226,E241,E305,E402,E722,E731,E741,W503,W504
max-line-length=100
exclude=cloudpickle.py,heapq3.py,shared.py,python/docs/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*
exclude=python/pyspark/cloudpickle/*.py,heapq3.py,shared.py,python/docs/conf.py,work/*/*.py,python/.eggs/*,dist/*,.git/*
Loading