[MINOR][R] Match collectAsArrowToR with non-streaming collectAsArrowToPython #29100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #125819 has finished for PR 29100 at commit
|
Member
How about something like |
Member
Author
|
I see, that case seems not working even after this fix. Let me forward port this first with #29098, and will work separately on that. |
Member
Author
|
I am going to merge this since this is just a forward-port that doesn't cause any behaviour change. I am 100% confident about this fix. |
Member
Author
|
Merged to master and branch-3.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 14, 2020
…oPython ### What changes were proposed in this pull request? This PR proposes to port forward #29098 to `collectAsArrowToR`. `collectAsArrowToR` follows `collectAsArrowToPython` in branch-2.4 due to the limitation of ARROW-4512. SparkR vectorization currently cannot use streaming format. ### Why are the changes needed? For simplicity and consistency. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The same code is being tested in `collectAsArrowToPython` of branch-2.4. Closes #29100 from HyukjinKwon/minor-parts. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 03b5707) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to port forward #29098 to
collectAsArrowToR.collectAsArrowToRfollowscollectAsArrowToPythonin branch-2.4 due to the limitation of ARROW-4512. SparkR vectorization currently cannot use streaming format.Why are the changes needed?
For simplicity and consistency.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The same code is being tested in
collectAsArrowToPythonof branch-2.4.