Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to fix the AppVeyor configuration to show all installed R packages with name/versions.

Before:

[1] '1.29'
[1] '2.3'
[1] '2.3.2'
[1] '1.7.3'
[1] '3.2.3'
[1] '0.17.1'

After:

                  Package  Version
arrow               arrow   0.17.1
askpass           askpass      1.1
assertthat     assertthat    0.2.1
backports       backports    1.1.8
base64enc       base64enc    0.1-3
bit                   bit 1.1-15.2
bit64               bit64    0.9-7
...

Why are the changes needed?

To show the package versions in a prettier way, and don't update the line every time when a package is added.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

AppVeyor CI should test it out.

@SparkQA
Copy link

SparkQA commented Jul 8, 2020

Test build #125349 has started for PR 29038 at commit c3985ad.

@HyukjinKwon
Copy link
Member Author

The tests failure in AppVeyor is orthogonal. It still prints fine the package information:

[00:01:52]                   Package  Version
[00:01:52] arrow               arrow   0.17.1
[00:01:52] assertthat     assertthat    0.2.1
[00:01:52] backports       backports    1.1.8
[00:01:52] base64enc       base64enc    0.1-3
[00:01:52] bit                   bit 1.1-15.2
[00:01:52] bit64               bit64    0.9-7
[00:01:52] callr               callr    3.4.3
[00:01:52] cli                   cli    2.0.2
[00:01:52] crayon             crayon    1.3.4
[00:01:52] desc                 desc    1.2.0
[00:01:52] digest             digest   0.6.25
[00:01:52] e1071               e1071    1.7-3
[00:01:52] ellipsis         ellipsis    0.3.1
[00:01:52] evaluate         evaluate     0.14
[00:01:52] fansi               fansi    0.4.1
[00:01:52] glue                 glue    1.4.1
[00:01:52] highr               highr      0.8
[00:01:52] htmltools       htmltools    0.5.0
[00:01:52] jsonlite         jsonlite    1.7.0
[00:01:52] knitr               knitr     1.29
[00:01:52] magrittr         magrittr      1.5
[00:01:52] markdown         markdown      1.1
[00:01:52] mime                 mime      0.9
[00:01:52] pkgbuild         pkgbuild    1.0.8
[00:01:52] pkgload           pkgload    1.1.0
[00:01:52] praise             praise    1.0.0
[00:01:52] prettyunits   prettyunits    1.1.1
[00:01:52] processx         processx    3.4.3
[00:01:52] ps                     ps    1.3.3
[00:01:52] purrr               purrr    0.3.4
[00:01:52] R6                     R6    2.4.1
[00:01:52] Rcpp                 Rcpp    1.0.5
[00:01:52] rlang               rlang    0.4.6
[00:01:52] rmarkdown       rmarkdown      2.3
[00:01:52] rprojroot       rprojroot    1.3-2
[00:01:52] rstudioapi     rstudioapi     0.11
[00:01:52] stringi           stringi    1.4.6
[00:01:52] stringr           stringr    1.4.0
[00:01:52] testthat         testthat    2.3.2
[00:01:52] tidyselect     tidyselect    1.1.0
[00:01:52] tinytex           tinytex     0.24
[00:01:52] vctrs               vctrs    0.3.1
[00:01:52] withr               withr    2.2.0
[00:01:52] xfun                 xfun     0.15
[00:01:52] yaml                 yaml    2.2.1
[00:01:52] translations translations    4.0.2

@HyukjinKwon HyukjinKwon requested a review from dongjoon-hyun July 8, 2020 14:19
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. I verified the result in AppVeyor. Thanks, @HyukjinKwon .
Merged to master.

@HyukjinKwon
Copy link
Member Author

Thanks @dongjoon-hyun.

@SparkQA
Copy link

SparkQA commented Jul 8, 2020

Test build #125364 has finished for PR 29038 at commit 91bbf8a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon deleted the minor-appveyor branch July 27, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants