[SPARK-30703][SQL][FOLLOWUP] Update SqlBase.g4 invalid comment #29033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @maropu |
maropu
approved these changes
Jul 8, 2020
maropu
pushed a commit
that referenced
this pull request
Jul 8, 2020
### What changes were proposed in this pull request? Modify the comment of `SqlBase.g4`. ### Why are the changes needed? `docs/sql-keywords.md` has already moved to `docs/sql-ref-ansi-compliance.md#sql-keywords`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need. Closes #29033 from ulysses-you/SPARK-30703-FOLLOWUP. Authored-by: ulysses <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]> (cherry picked from commit 65286ae) Signed-off-by: Takeshi Yamamuro <[email protected]>
Member
|
Looks okay and this PR is not related to the tests. So, I've merged it into master/3.0. |
Contributor
Author
|
thanks for merging! |
|
Test build #125280 has finished for PR 29033 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify the comment of
SqlBase.g4.Why are the changes needed?
docs/sql-keywords.mdhas already moved todocs/sql-ref-ansi-compliance.md#sql-keywords.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.