Skip to content

[SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable. #29029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 1 commit into from
Closed

[SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable. #29029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ object EvaluatePython {

case udt: UserDefinedType[_] => makeFromJava(udt.sqlType)

case other => (obj: Any) => nullSafeConvert(other)(PartialFunction.empty)
case other => (obj: Any) => nullSafeConvert(obj)(PartialFunction.empty)
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sarutak . Can we have a test case for this?

Copy link
Member

@maropu maropu Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@maropu maropu Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, for any input, this converter in this pattern returns null? I mean we cannot write it here like this?

case other => (_: Any) => null

Copy link
Member Author

@sarutak sarutak Jul 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, for any input, this converter in this pattern returns null?

Yes so it's difficult to test based on the return value.
Or, how about testing that the converter still returns null, meaning there is no regression?

Copy link
Member

@HyukjinKwon HyukjinKwon Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way seems fine to me

}

private def nullSafeConvert(input: Any)(f: PartialFunction[Any, Any]): Any = {
Expand Down