[SPARK-32164][ML] GeneralizedLinearRegressionSummary optimization #28990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
retest this please |
huaxingao
reviewed
Jul 5, 2020
|
|
||
| private[regression] lazy val link: Link = familyLink.link | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
super nit: extra blank line?
| lazy val numInstances: Long = predictions.count() | ||
| lazy val numInstances: Long = glrSummary.getLong(0) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
remove this extra blank line too?
Contributor
|
The changes make sense to me. |
srowen
approved these changes
Jul 5, 2020
|
Test build #124927 has finished for PR 28990 at commit
|
Member
|
Retest this please |
|
Test build #124983 has finished for PR 28990 at commit
|
|
Test build #124997 has finished for PR 28990 at commit
|
huaxingao
approved these changes
Jul 6, 2020
Contributor
|
I will merge this PR :) |
Contributor
|
Merged to master. Thanks everyone! |
Contributor
Author
|
thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, GeneralizedLinearRegressionSummary compute several statistics on single pass
2, LinearRegressionSummary use metrics.count
Why are the changes needed?
avoid extra passes on the dataset
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites