Skip to content

[MINOR][SQL] Fix spaces in JDBC connection providers #28945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborgsomogyi wants to merge 1 commit into from
Closed

[MINOR][SQL] Fix spaces in JDBC connection providers #28945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../org/apache/spark/sql/execution/datasources/jdbc/connection/BasicConnectionProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import scala.collection.JavaConverters._
import org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions

private[jdbc] class BasicConnectionProvider(driver: Driver, options: JDBCOptions)
extends ConnectionProvider {
extends ConnectionProvider {
def getConnection(): Connection = {
val properties = getAdditionalProperties()
options.asConnectionProperties.entrySet().asScala.foreach { e =>
Expand Down
2 changes: 1 addition & 1 deletion ...la/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import org.apache.hadoop.security.UserGroupInformation
import org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions

private[sql] class DB2ConnectionProvider(driver: Driver, options: JDBCOptions)
extends SecureConnectionProvider(driver, options) {
extends SecureConnectionProvider(driver, options) {
override val appEntry: String = "JaasClient"

override def getConnection(): Connection = {
Expand Down
2 changes: 1 addition & 1 deletion ...rg/apache/spark/sql/execution/datasources/jdbc/connection/MariaDBConnectionProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import java.sql.Driver
import org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions

private[jdbc] class MariaDBConnectionProvider(driver: Driver, options: JDBCOptions)
extends SecureConnectionProvider(driver, options) {
extends SecureConnectionProvider(driver, options) {
override val appEntry: String = {
"Krb5ConnectorContext"
}
Expand Down
2 changes: 1 addition & 1 deletion ...g/apache/spark/sql/execution/datasources/jdbc/connection/PostgresConnectionProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import java.util.Properties
import org.apache.spark.sql.execution.datasources.jdbc.JDBCOptions

private[jdbc] class PostgresConnectionProvider(driver: Driver, options: JDBCOptions)
extends SecureConnectionProvider(driver, options) {
extends SecureConnectionProvider(driver, options) {
override val appEntry: String = {
val parseURL = driver.getClass.getMethod("parseURL", classOf[String], classOf[Properties])
val properties = parseURL.invoke(driver, options.url, null).asInstanceOf[Properties]
Expand Down
2 changes: 1 addition & 1 deletion ...org/apache/spark/sql/execution/datasources/jdbc/connection/SecureConnectionProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import org.apache.spark.util.SecurityUtils
private[connection] object SecurityConfigurationLock

private[jdbc] abstract class SecureConnectionProvider(driver: Driver, options: JDBCOptions)
extends BasicConnectionProvider(driver, options) with Logging {
extends BasicConnectionProvider(driver, options) with Logging {
override def getConnection(): Connection = {
setAuthenticationConfigIfNeeded()
super.getConnection()
Expand Down