[SPARK-32126][SS] Scope Session.active in IncrementalExecution #28936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #124589 has finished for PR 28936 at commit
|
Member
Author
|
retest this please |
|
Test build #124595 has finished for PR 28936 at commit
|
dongjoon-hyun
requested changes
Jun 28, 2020
Member
There was a problem hiding this comment.
Thanks, @xuanyuanking . BTW, since Apache Spark 3.0.0 is already released and this patch only is applicable for Apache Spark 3.0.1. So, could you file a new JIRA for this PR? Otherwise, we will lose the traceability for this patch.
cloud-fan
approved these changes
Jun 29, 2020
Contributor
cloud-fan
left a comment
cloud-fan
left a comment
There was a problem hiding this comment.
LGTM, let's create a new JIRA ticket
dongjoon-hyun
changed the title
Member
|
Thanks, @xuanyuanking and @cloud-fan . I created SPARK-32126 and update the title. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 29, 2020
### What changes were proposed in this pull request? The `optimizedPlan` in IncrementalExecution should also be scoped in `withActive`. ### Why are the changes needed? Follow-up of SPARK-30798 for the Streaming side. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UT. Closes #28936 from xuanyuanking/SPARK-30798-follow. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit f944603) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Sorry for the late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
optimizedPlanin IncrementalExecution should also be scoped inwithActive.Why are the changes needed?
Follow-up of SPARK-30798 for the Streaming side.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.