[SPARK-32089][R][BUILD] Upgrade R version to 4.0.2 in the release DockerFiile #28922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @shivaram too |
HyukjinKwon
changed the title
|
Test build #124484 has finished for PR 28922 at commit
|
shivaram
approved these changes
Jun 24, 2020
Contributor
shivaram
left a comment
shivaram
left a comment
There was a problem hiding this comment.
LGTM. Thanks @HyukjinKwon
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jun 24, 2020
…kerFiile ### What changes were proposed in this pull request? This PR proposes to upgrade R version to 4.0.2 in the release docker image. As of SPARK-31918, we should make a release with R 4.0.0+ which works with R 3.5+ too. ### Why are the changes needed? To unblock releases on CRAN. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually tested via scripts under `dev/create-release`, manually attaching to the container and checking the R version. Closes #28922 from HyukjinKwon/SPARK-32089. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 71b6d46) Signed-off-by: Wenchen Fan <[email protected]>
Member
|
Nice, @HyukjinKwon . |
Contributor
|
@HyukjinKwon could we also merge this in branch-2.4? If we build a 2.4.7 release we should use R 4.0 for that cc @holdenk |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 1, 2020
…kerFiile This PR proposes to upgrade R version to 4.0.2 in the release docker image. As of SPARK-31918, we should make a release with R 4.0.0+ which works with R 3.5+ too. To unblock releases on CRAN. No, dev-only. Manually tested via scripts under `dev/create-release`, manually attaching to the container and checking the R version. Closes #28922 from HyukjinKwon/SPARK-32089. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Member
Author
|
@shivaram, I ported back by logically resolving conflicts; however, it wasn't tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to upgrade R version to 4.0.2 in the release docker image. As of SPARK-31918, we should make a release with R 4.0.0+ which works with R 3.5+ too.
Why are the changes needed?
To unblock releases on CRAN.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually tested via scripts under
dev/create-release, manually attaching to the container and checking the R version.