[SPARK-32078][DOC] Add a redirect to sql-ref from sql-reference #28914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
gatorsmile
commented
Jun 24, 2020
| --- | ||
| layout: global | ||
| title: SQL Reference | ||
| redirect_from: /sql-reference |
Member
Author
There was a problem hiding this comment.
We should do the same things in the future if we need to rename the files.
|
Test build #124439 has finished for PR 28914 at commit
|
Contributor
|
I did a quick try to make sure the re-direct works on my laptop. |
HyukjinKwon
approved these changes
Jun 24, 2020
Contributor
|
Looks good. Will follow this approach if need to rename files in the future. |
dongjoon-hyun
approved these changes
Jun 24, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @gatorsmile and all.
Merged to master/branch-3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 24, 2020
### What changes were proposed in this pull request? This PR is to add a redirect to sql-ref.html. ### Why are the changes needed? Before Spark 3.0 release, we are using sql-reference.md, which was replaced by sql-ref.md instead. A number of Google searches I’ve done today have turned up https://spark.apache.org/docs/latest/sql-reference.html, which does not exist any more. Thus, we should add a redirect to sql-ref.html. ### Does this PR introduce _any_ user-facing change? https://spark.apache.org/docs/latest/sql-reference.html will be redirected to https://spark.apache.org/docs/latest/sql-ref.html ### How was this patch tested? Build it in my local environment. It works well. The sql-reference.html file was generated. The contents are like: ``` <!DOCTYPE html> <html lang="en-US"> <meta charset="utf-8"> <title>Redirecting…</title> <link rel="canonical" href="http://localhost:4000/sql-ref.html"> <script>location="http://localhost:4000/sql-ref.html"</script> <meta http-equiv="refresh" content="0; url=http://localhost:4000/sql-ref.html"> <meta name="robots" content="noindex"> <h1>Redirecting…</h1> <a href="http://localhost:4000/sql-ref.html">Click here if you are not redirected.</a> </html> ``` Closes #28914 from gatorsmile/addRedirectSQLRef. Authored-by: gatorsmile <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit d06604f) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to add a redirect to sql-ref.html.
Why are the changes needed?
Before Spark 3.0 release, we are using sql-reference.md, which was replaced by sql-ref.md instead. A number of Google searches I’ve done today have turned up https://spark.apache.org/docs/latest/sql-reference.html, which does not exist any more. Thus, we should add a redirect to sql-ref.html.
Does this PR introduce any user-facing change?
https://spark.apache.org/docs/latest/sql-reference.html will be redirected to https://spark.apache.org/docs/latest/sql-ref.html
How was this patch tested?
Build it in my local environment. It works well. The sql-reference.html file was generated. The contents are like: