-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-31801][API][SHUFFLE][TESTS] Tests for registering map output metadata #28902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-31801][API][SHUFFLE][TESTS] Tests for registering map output metadata #28902
Conversation
This reverts commit dc8d15c.
|
Test build #124384 has finished for PR 28902 at commit
|
…metadata-with-tests
…metadata-with-tests
|
Test build #126832 has finished for PR 28902 at commit
|
|
Test build #126834 has finished for PR 28902 at commit
|
|
Test build #126835 has finished for PR 28902 at commit
|
Only invoke shuffle output tracker once per unregister shuffle attempt.
…metadata-with-tests
|
Test build #126895 has finished for PR 28902 at commit
|
|
Test build #126903 has finished for PR 28902 at commit
|
Cause we need to stop the SC
…metadata-with-tests
|
Test build #126997 has finished for PR 28902 at commit
|
…metadata-with-tests
|
Test build #127001 has finished for PR 28902 at commit
|
|
Test build #127011 has finished for PR 28902 at commit
|
|
Test build #127294 has finished for PR 28902 at commit
|
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
Builds on #28618 in providing tests via a mock implementation of the shuffle plugin system. Note that a proper review of this should be done via comparing to #28618. Check out mccheah/spark@register-map-output-metadata...mccheah:register-map-output-metadata-with-tests for a more illustrative diff, at least until the dependent PR merges into maste.
Requires #28618.
Why are the changes needed?
We aim to provide test coverage to ensure the plugin system works in a meaningful way. Additionally, it's important to provide a reference implementation for plugin developers to look at.
Does this PR introduce any user-facing change?
No - tests only
How was this patch tested?
The patch should be entirely tests.