Skip to content

[SPARK-32062][SQL] Reset listenerRegistered in SparkSession #28899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulysses-you wants to merge 4 commits into from
Closed

[SPARK-32062][SQL] Reset listenerRegistered in SparkSession #28899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d6ece0
init
ulysses-you Jun 23, 2020
fb88f3a
add ut
ulysses-you Jun 23, 2020
a486f1f
update ut
ulysses-you Jun 23, 2020
708c9ff
fix
ulysses-you Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,7 @@ object SparkSession extends Logging {
sparkContext.addSparkListener(new SparkListener {
override def onApplicationEnd(applicationEnd: SparkListenerApplicationEnd): Unit = {
defaultSession.set(null)
listenerRegistered.set(false)
}
})
listenerRegistered.set(true)
Expand Down
17 changes: 17 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,4 +240,21 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach {
assert(session.conf.get(GLOBAL_TEMP_DATABASE) === "globaltempdb-spark-31532-2")
assert(session.conf.get(WAREHOUSE_PATH) === "SPARK-31532-db-2")
}

test("SPARK-32062: reset listenerRegistered in SparkSession") {
Copy link
Contributor

@cloud-fan cloud-fan Jun 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test relies on other tests to create and stop spark session, which is fragile.

Can we explicitly create and stop a spark session in this test?

(1 to 2).foreach { i =>
val conf = new SparkConf()
.setMaster("local")
.setAppName(s"test-SPARK-32062-$i")
val context = new SparkContext(conf)
Copy link
Contributor

@cloud-fan cloud-fan Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work? The test doesn't stop the spark context, and AFAIK we don't support having multiple spark context instance at the same time.

Copy link
Contributor Author

@ulysses-you ulysses-you Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed it.

val beforeListenerSize = context.listenerBus.listeners.size()
SparkSession
.builder()
.sparkContext(context)
.getOrCreate()
val afterListenerSize = context.listenerBus.listeners.size()
assert(beforeListenerSize + 1 == afterListenerSize)
context.stop()
}
}
}