[SPARK-32052][SQL] Extract common code from date-time field expressions #28894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #124365 has finished for PR 28894 at commit
|
MaxGekk
commented
Jun 22, 2020
| case class Hour(child: Expression, timeZoneId: Option[String] = None) | ||
| extends UnaryExpression with TimeZoneAwareExpression with ImplicitCastInputTypes | ||
| with NullIntolerant { | ||
| trait GetTimeField extends UnaryExpression |
Member
Author
There was a problem hiding this comment.
When I made it as abstract class with 2 args func and funcName, I got the following exception on tests from DateExpressionsSuite:
org.apache.spark.sql.catalyst.expressions.Second; no valid constructor
java.io.InvalidClassException: org.apache.spark.sql.catalyst.expressions.Second; no valid constructor
at java.io.ObjectStreamClass$ExceptionInfo.newInvalidClassException(ObjectStreamClass.java:169)
at java.io.ObjectStreamClass.checkDeserialize(ObjectStreamClass.java:885)
at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2100)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1625)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:465)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:423)
at org.apache.spark.serializer.JavaDeserializationStream.readObject(JavaSerializer.scala:76)
at org.apache.spark.serializer.JavaSerializerInstance.deserialize(JavaSerializer.scala:109)
at org.apache.spark.sql.catalyst.expressions.ExpressionEvalHelper.prepareEvaluation(ExpressionEvalHelper.scala:75)
I decided to leave it as a trait.
Member
Author
|
@cloud-fan @srowen @dongjoon-hyun @HyukjinKwon Could you review the refactoring, please. |
cloud-fan
approved these changes
Jun 23, 2020
Contributor
|
thanks, merging to master! |
Member
|
late LGTM too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extract common code from the expressions that get date or time fields from input dates/timestamps to new expressions
GetDateFieldandGetTimeField, and re-use the common traits from the affected classes.Why are the changes needed?
Code deduplication improves maintainability.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By
DateExpressionsSuite