[MINOR][SQL] Simplify DateTimeUtils.cleanLegacyTimestampStr #28892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #124358 has finished for PR 28892 at commit
|
|
Test build #124359 has finished for PR 28892 at commit
|
Member
Author
|
@srowen @dongjoon-hyun @cloud-fan @HyukjinKwon Could you review the little refactoring. |
cloud-fan
reviewed
Jun 23, 2020
| } | ||
| } | ||
| // the "GMT" string. For example, it returns 2000-01-01T00:00+01:00 for 2000-01-01T00:00GMT+01:00. | ||
| def cleanLegacyTimestampStr(s: UTF8String): UTF8String = s.replace(gmtUtf8, UTF8String.EMPTY_UTF8) |
Contributor
There was a problem hiding this comment.
doesn't the java.lang.String have the replace method?
Member
Author
There was a problem hiding this comment.
It has but look at how it is implemented via regexp. @JoshRosen implemented more effective replace in UTF8String #24707. That's why I took it. I hope it seems reasonable.
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Call the
replace()method fromUTF8Stringto remove theGMTstring from the input ofDateTimeUtils.cleanLegacyTimestampStr. It removes allGMTsubstrings.Why are the changes needed?
Simpler code improves maintainability
Does this PR introduce any user-facing change?
Should not
How was this patch tested?
By existing test suites
JsonSuiteandUnivocityParserSuite.