Skip to content

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Jun 22, 2020

This is a followup of #28861 :

  1. sort the names by Github ID, suggested by [MINOR] update dev/create-release/known_translations #28861 (review)
  2. add more full names collected in [MINOR] update dev/create-release/known_translations #28861
  3. The duplicated entry of linbojin is removed.
  4. Name format is normalized to First Last name style.

@cloud-fan
Copy link
Contributor Author

I'll keep this PR open for a few more days, to collect more names in #28861

@cloud-fan
Copy link
Contributor Author

cc @srowen @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cloud-fan . Since this will be updated continuously, I checked only the AS-IS and compared with master branch. Names looks correct.
In the PR description, could you mentioned the followings roughly?

  1. The duplicated entry of linbojin is removed.
244d243
< linbojin - Linbo Jin
  1. Name format is normalized to First Last name style.
< LinhongLiu - Liu, Linhong
---
> LinhongLiu - Linhong Liu

@cloud-fan
Copy link
Contributor Author

Done

@dongjoon-hyun
Copy link
Member

Thanks~

@SparkQA
Copy link

SparkQA commented Jun 22, 2020

Test build #124357 has finished for PR 28891 at commit 4731d94.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 23, 2020

Test build #124423 has finished for PR 28891 at commit 738fe25.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Jun 29, 2020

no more updates from #28861 , I'm merging to master, thanks!

@cloud-fan cloud-fan closed this in a6b6a1f Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants