[SPARK-32028][WEBUI] fix app id link for multi attempts app in history summary page #28867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dongjoon-hyun , @vanzin, @jerryshao , could you please help review this? |
Member
|
ok to test |
|
Test build #124265 has finished for PR 28867 at commit
|
Member
|
Retest this please. |
|
Test build #124303 has finished for PR 28867 at commit
|
srowen
reviewed
Jun 20, 2020
core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
Show resolved
Hide resolved
srowen
reviewed
Jun 22, 2020
core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
Show resolved
Hide resolved
srowen
approved these changes
Jun 22, 2020
Contributor
Author
|
@srowen , thank you for your reviewing. |
srowen
pushed a commit
that referenced
this pull request
Jun 24, 2020
…y summary page ### What changes were proposed in this pull request? Fix app id link for multi attempts application in history summary page If attempt id is available (yarn), app id link url will contain correct attempt id, like `/history/application_1561589317410_0002/1/jobs/`. If attempt id is not available (standalone), app id link url will not contain fake attempt id, like `/history/app-20190404053606-0000/jobs/`. ### Why are the changes needed? This PR is for fixing [32028](https://issues.apache.org/jira/browse/SPARK-32028). App id link use application attempt count as attempt id. this would cause link url wrong for below cases: 1. there are multi attempts, all links point to last attempt  2. if there is one attempt, but attempt id is not 1 (before attempt maybe crash or fail to gerenerate event file). link url points to worng attempt (1) here.  ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tested this manually. Closes #28867 from zhli1142015/fix-appid-link-in-history-page. Authored-by: Zhen Li <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit eedc6cc) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/3.0 |
Member
|
Hi, All. |
Member
|
Yes could go back into 2.4.x. I'll try to cherry-pick. |
Member
|
Thank you, @srowen ! |
srowen
pushed a commit
to srowen/spark
that referenced
this pull request
Jun 29, 2020
…y summary page Fix app id link for multi attempts application in history summary page If attempt id is available (yarn), app id link url will contain correct attempt id, like `/history/application_1561589317410_0002/1/jobs/`. If attempt id is not available (standalone), app id link url will not contain fake attempt id, like `/history/app-20190404053606-0000/jobs/`. This PR is for fixing [32028](https://issues.apache.org/jira/browse/SPARK-32028). App id link use application attempt count as attempt id. this would cause link url wrong for below cases: 1. there are multi attempts, all links point to last attempt  2. if there is one attempt, but attempt id is not 1 (before attempt maybe crash or fail to gerenerate event file). link url points to worng attempt (1) here.  No Tested this manually. Closes apache#28867 from zhli1142015/fix-appid-link-in-history-page. Authored-by: Zhen Li <[email protected]> Signed-off-by: Sean Owen <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 1, 2020
…istory summary page This is simply a backport of #28867 to branch-2.4 Closes #28949 from srowen/SPARK-32028.2. Authored-by: Zhen Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix app id link for multi attempts application in history summary page
If attempt id is available (yarn), app id link url will contain correct attempt id, like
/history/application_1561589317410_0002/1/jobs/.If attempt id is not available (standalone), app id link url will not contain fake attempt id, like
/history/app-20190404053606-0000/jobs/.Why are the changes needed?
This PR is for fixing 32028. App id link use application attempt count as attempt id. this would cause link url wrong for below cases:
there are multi attempts, all links point to last attempt
if there is one attempt, but attempt id is not 1 (before attempt maybe crash or fail to gerenerate event file). link url points to worng attempt (1) here.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested this manually.