Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Jun 16, 2020

What changes were proposed in this pull request?

This PR proposes to specify the version of ChromeDriver and RemoteWebDriver which work with guava 14.0.1 explicitly.

Why are the changes needed?

#28585 (SPARK-31765) upgraded HtmlUnit due to a security reason and Selenium was also needed to be upgraded to work with the upgraded HtmlUnit.
After upgrading Selenium, ChromeDriver and RemoteWebDriver are implicitly upgraded because of dependency and the implicitly upgraded modules can't work with guava 14.0.1 due to an API compatibility so we need to run ChromeUISeleniumSuite with a guava version specified like -Dguava.version=25.0-jre.

$ build/sbt -Dguava.version=25.0-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags= "testOnly org.apache.spark.ui.UISeleniumSuite"

It's a little bit inconvenience so let's use older version which can work with guava 14.0.1.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Confirmed that the following test can finish successfully.

build/sbt -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags=  clean "testOnly org.apache.spark.ui.ChromeUISeleniumSuite"
build/mvn -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags=  -Dtest=none -DwildcardSuites="org.apache.spark.ui.ChromeUISeleniumSuite" clean test

@sarutak
Copy link
Member Author

sarutak commented Jun 16, 2020

Note for reviewers that this fix affects tests with both sbt and Maven so we need to test with sbt and Maven.
Tests with sbt runs first and I'll run tests with Maven after the sbt test passes.

@SparkQA
Copy link

SparkQA commented Jun 16, 2020

Test build #124094 has finished for PR 28837 at commit 6a1e8c0.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jun 16, 2020

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 16, 2020

Test build #124106 has finished for PR 28837 at commit 6a1e8c0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jun 16, 2020

I've noticed that it's impossible to resolve the test failure with RemoteDriver downgraded so I'll close this PR for now.

@sarutak sarutak closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants