[SPARK-31992][SQL] Benchmark the EXCEPTION rebase mode #28829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #124016 has finished for PR 28829 at commit
|
Member
Author
|
jenkins, retest this, please |
MaxGekk
changed the title
Member
Author
|
@cloud-fan Please, review the PR |
|
Test build #124033 has finished for PR 28829 at commit
|
Contributor
|
retest this please |
Contributor
|
This updates benchmark only and doesn't affect jenkins builder, I'm merging it to master/3.0, thanks! |
cloud-fan
pushed a commit
that referenced
this pull request
Jun 15, 2020
### What changes were proposed in this pull request? - Modify `DateTimeRebaseBenchmark` to benchmark the default date-time rebasing mode - `EXCEPTION` for saving/loading dates/timestamps from/to parquet files. The mode is benchmarked for modern timestamps after 1900-01-01 00:00:00Z and dates after 1582-10-15. - Regenerate benchmark results in the environment: | Item | Description | | ---- | ----| | Region | us-west-2 (Oregon) | | Instance | r3.xlarge | | AMI | ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-amd64-server-20190722.1 (ami-06f2f779464715dc5) | | Java | OpenJDK 64-Bit Server VM 1.8.0_252 and OpenJDK 64-Bit Server VM 11.0.7+10 | ### Why are the changes needed? The `EXCEPTION` rebasing mode is the default mode of the SQL configs `spark.sql.legacy.parquet.datetimeRebaseModeInRead` and `spark.sql.legacy.parquet.datetimeRebaseModeInWrite`. The changes are needed to improve benchmark coverage for default settings. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By running the benchmark and check results manually. Closes #28829 from MaxGekk/benchmark-exception-mode. Authored-by: Max Gekk <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 9d95f1b) Signed-off-by: Wenchen Fan <[email protected]>
|
Test build #124039 has finished for PR 28829 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DateTimeRebaseBenchmarkto benchmark the default date-time rebasing mode -EXCEPTIONfor saving/loading dates/timestamps from/to parquet files. The mode is benchmarked for modern timestamps after 1900-01-01 00:00:00Z and dates after 1582-10-15.Why are the changes needed?
The
EXCEPTIONrebasing mode is the default mode of the SQL configsspark.sql.legacy.parquet.datetimeRebaseModeInReadandspark.sql.legacy.parquet.datetimeRebaseModeInWrite. The changes are needed to improve benchmark coverage for default settings.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the benchmark and check results manually.