[SPARK-31983][WEBUI][3.0] Fix sorting for duration column in structured streaming tab #28823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRakson
changed the title
Contributor
Author
|
Test build #123978 has finished for PR 28823 at commit
|
sarutak
pushed a commit
that referenced
this pull request
Jun 15, 2020
…ed streaming tab ### What changes were proposed in this pull request? Sorting result for duration column in tables of structured streaming tab is wrong sometimes. <img width="1677" alt="Screenshot 2020-06-13 at 1 58 53 PM" src="https://user-images.githubusercontent.com/15366835/84572178-10755700-adb6-11ea-9131-338e8ba7fb24.png"> We are sorting on string, which results in this behaviour. `sorttable_numeric` and `sorttable_customkey` is used to fix this. Refer [this](#28752 (comment)) and [this](#28752 (comment)) After changes : <img width="1677" alt="Screenshot 2020-06-13 at 8 05 32 PM" src="https://user-images.githubusercontent.com/15366835/84572299-a8734080-adb6-11ea-9aa3-b4bc594de4cf.png"> ### Why are the changes needed? Sorting results are wrong for duration column in tables of structured streaming tab. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Screenshots attached. Closes #28823 from iRakson/testsort. Authored-by: iRakson <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
Member
|
LGTM. Merged to |
Contributor
Author
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jun 25, 2020
…ed streaming tab ### What changes were proposed in this pull request? Sorting result for duration column in tables of structured streaming tab is wrong sometimes. <img width="1677" alt="Screenshot 2020-06-13 at 1 58 53 PM" src="https://user-images.githubusercontent.com/15366835/84572178-10755700-adb6-11ea-9131-338e8ba7fb24.png"> We are sorting on string, which results in this behaviour. `sorttable_numeric` and `sorttable_customkey` is used to fix this. Refer [this](apache#28752 (comment)) and [this](apache#28752 (comment)) After changes : <img width="1677" alt="Screenshot 2020-06-13 at 8 05 32 PM" src="https://user-images.githubusercontent.com/15366835/84572299-a8734080-adb6-11ea-9aa3-b4bc594de4cf.png"> ### Why are the changes needed? Sorting results are wrong for duration column in tables of structured streaming tab. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Screenshots attached. Closes apache#28823 from iRakson/testsort. Authored-by: iRakson <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Sorting result for duration column in tables of structured streaming tab is wrong sometimes.
We are sorting on string, which results in this behaviour.
sorttable_numericandsorttable_customkeyis used to fix this.Refer this and this
After changes :
Why are the changes needed?
Sorting results are wrong for duration column in tables of structured streaming tab.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Screenshots attached.