Skip to content

[SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing #28812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing #28812

HyukjinKwon wants to merge 1 commit into from

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jun 12, 2020

What changes were proposed in this pull request?

This proposes a minor refactoring to match NestedColumnAliasing to GeneratorNestedColumnAliasing so it returns the pruned plan directly.

    case p @ NestedColumnAliasing(nestedFieldToAlias, attrToAliases) =>
      NestedColumnAliasing.replaceToAliases(p, nestedFieldToAlias, attrToAliases)

vs

    case GeneratorNestedColumnAliasing(p) => p

Why are the changes needed?

Just for readability.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests should cover.

@HyukjinKwon HyukjinKwon requested a review from viirya June 12, 2020 08:24
@SparkQA
Copy link

SparkQA commented Jun 12, 2020

Test build #123911 has finished for PR 28812 at commit d3a9bef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

viirya
viirya reviewed Jun 12, 2020
View reviewed changes
Copy link
Member

@viirya viirya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the description correct? I cannot find GeneratorNestedColumnAliasing in the diff.

nvm, I mis-read the description. Just getting up.

@maropu maropu closed this in a620a2a Jun 12, 2020
@maropu
Copy link
Member

maropu commented Jun 12, 2020

okay, thanks! Merged to master.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jun 14, 2020

Thanks @viirya and @maropu!

@HyukjinKwon HyukjinKwon deleted the SPARK-31977 branch July 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

@maropu maropu maropu approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HyukjinKwon @SparkQA @maropu @viirya