Skip to content

[SPARK-31950][SQL][TESTS] Extract SQL keywords from the SqlBase.g4 file #28802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maropu wants to merge 7 commits into from
Closed

[SPARK-31950][SQL][TESTS] Extract SQL keywords from the SqlBase.g4 file #28802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fdd1bcb
Fix
maropu Jun 11, 2020
d748882
review
maropu Jun 11, 2020
349b919
review
maropu Jun 12, 2020
3c1ce72
minor fix
maropu Jun 12, 2020
09a2ed4
review
maropu Jun 12, 2020
80b1c3a
Fix
maropu Jun 12, 2020
bd2c6bc
fix
maropu Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,6 +1009,7 @@ alterColumnAction
// You can find the full keywords list by searching "Start of the keywords list" in this file.
// The non-reserved keywords are listed below. Keywords not in this list are reserved keywords.
ansiNonReserved
//--ANSI-NON-RESERVED-START
: ADD
| AFTER
| ALTER
Expand Down Expand Up @@ -1185,6 +1186,7 @@ ansiNonReserved
| VIEW
| VIEWS
| WINDOW
//--ANSI-NON-RESERVED-END
;

// When `SQL_standard_keyword_behavior=false`, there are 2 kinds of keywords in Spark SQL.
Expand All @@ -1197,6 +1199,7 @@ ansiNonReserved
// The non-reserved keywords are listed in `nonReserved`.
// These 2 together contain all the keywords.
strictNonReserved
//--ANSI-STRICT-NON-RESERVED-START

@cloud-fan cloud-fan Jun 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not ansi, we should just call it STRICT-NON-RESERVED

@maropu maropu Jun 11, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I missed that. I'll update soon.

: ANTI
| CROSS
| EXCEPT
Expand All @@ -1212,6 +1215,7 @@ strictNonReserved
| SETMINUS
| UNION
| USING
//--ANSI-STRICT-NON-RESERVED-END
;

nonReserved
Expand Down Expand Up @@ -1462,6 +1466,7 @@ nonReserved
//============================
// Start of the keywords list
//============================
//--SPARK-KEYWORD-LIST-START
ADD: 'ADD';
AFTER: 'AFTER';
ALL: 'ALL';
Expand Down Expand Up @@ -1714,6 +1719,7 @@ WHERE: 'WHERE';
WINDOW: 'WINDOW';
WITH: 'WITH';
YEAR: 'YEAR';
//--SPARK-KEYWORD-LIST-END
//============================
// End of the keywords list
//============================
Expand Down
Loading