Skip to content

[SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3 #28796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 3 commits into from
Closed

[SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3 #28796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
036864b
fix test case for hadoop 3.2
gengliangwang Jun 11, 2020
58b5159
update tests
gengliangwang Jun 11, 2020
e3bb417
update
gengliangwang Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
assert(message.equals("No FileSystem for scheme: nonexistsFs"))
val expectMessage = "No FileSystem for scheme nonexistsFs"
assert(message.filterNot(Set(':', '"').contains) == expectMessage)
}
}

Expand Down
4 changes: 2 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,11 +536,11 @@ class FileStreamSourceSuite extends FileStreamSourceTest {
withTempDir { dir =>
val path = dir.getCanonicalPath
val defaultFs = "nonexistFS://nonexistFS"
val expectMessage = "No FileSystem for scheme: nonexistFS"
val expectMessage = "No FileSystem for scheme nonexistFS"
val message = intercept[java.io.IOException] {
spark.readStream.option("fs.defaultFS", defaultFs).text(path)
}.getMessage
assert(message == expectMessage)
assert(message.filterNot(Set(':', '"').contains) == expectMessage)
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove : at line 539, too.

}
}

Expand Down