[SPARK-31950][SQL][TESTS] Extract SQL keywords from the generated parser class #28779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
commented
Jun 10, 2020
| "except", | ||
| "false", | ||
| "fetch", | ||
| "filter", |
Member
Author
There was a problem hiding this comment.
I noticed that we forgot to add this word in this list by this change.
maropu
commented
Jun 10, 2020
| "with", | ||
| "year") | ||
| // All the SQL keywords defined in `SqlBase.g4` | ||
| val allCandidateKeywords = { |
Member
Author
There was a problem hiding this comment.
Note: I've checked that (the existing allCandidateKeywords -- this new allCandidateKeywords) is empty.
maropu
changed the title
Member
Author
|
How about this update? @cloud-fan @viirya @dilipbiswal |
|
Test build #123740 has finished for PR 28779 at commit
|
Contributor
|
I'm thinking about a text-based solution: we add a special line before the keyword section, and another special line after the key work section, then we just read the sqlbase.g4, find the keword section. We can use it to get ansi reserverd/non-reserved keywords as well. |
Member
Author
|
Ah, I see. I'll update based on the suggestion tomorrow. |
Member
|
Text-based solution sounds good. |
Member
Author
dbtsai
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jun 12, 2020
### What changes were proposed in this pull request? This PR intends to extract SQL reserved/non-reserved keywords from the ANTLR grammar file (`SqlBase.g4`) directly. This approach is based on the cloud-fan suggestion: apache#28779 (comment) ### Why are the changes needed? It is hard to maintain a full set of the keywords in `TableIdentifierParserSuite`, so it would be nice if we could extract them from the `SqlBase.g4` file directly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#28802 from maropu/SPARK-31950-2. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
maropu
added a commit
that referenced
this pull request
Jun 15, 2020
### What changes were proposed in this pull request? This PR intends to extract SQL reserved/non-reserved keywords from the ANTLR grammar file (`SqlBase.g4`) directly. This approach is based on the cloud-fan suggestion: #28779 (comment) ### Why are the changes needed? It is hard to maintain a full set of the keywords in `TableIdentifierParserSuite`, so it would be nice if we could extract them from the `SqlBase.g4` file directly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #28802 from maropu/SPARK-31950-2. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jun 25, 2020
### What changes were proposed in this pull request? This PR intends to extract SQL reserved/non-reserved keywords from the ANTLR grammar file (`SqlBase.g4`) directly. This approach is based on the cloud-fan suggestion: apache#28779 (comment) ### Why are the changes needed? It is hard to maintain a full set of the keywords in `TableIdentifierParserSuite`, so it would be nice if we could extract them from the `SqlBase.g4` file directly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#28802 from maropu/SPARK-31950-2. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR intends to extract SQL keywords (
allCandidateKeywordsinTableIdentifierParserSuite) from the generated parser class.Why are the changes needed?
It is hard to maintain a full set of SQL keywords in
TableIdentifierParserSuite, so it would be nice if we could updateallCandidateKeywordsautomatically.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.