Skip to content

Conversation

@manuzhang
Copy link
Member

@manuzhang manuzhang commented Jun 9, 2020

What changes were proposed in this pull request?

This reverts commit b9737c3 while keeping following changes

  • set default value of spark.sql.adaptive.skewJoin.skewedPartitionFactor to 5
  • improve tests
  • remove unused imports

Why are the changes needed?

As discussed in #28669 (comment), revert SPARK-31864 for optimizing skew join to work for extremely clustered keys.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@cloud-fan
Copy link
Contributor

OK to test

@cloud-fan
Copy link
Contributor

ok to test

@cloud-fan
Copy link
Contributor

add to whitelist

@SparkQA
Copy link

SparkQA commented Jun 10, 2020

Test build #123748 has finished for PR 28770 at commit f806c9a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan cloud-fan changed the title [SPARK-31942] Revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition [SPARK-31942] Partially revert "[SPARK-31864][SQL] Adjust AQE skew join trigger condition Jun 11, 2020
@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 5d78537 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants