Skip to content

[SPARK-31941][CORE] Replace SparkException to NoSuchElementException for applicationInfo in AppStatusStore #28768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SaurabhChawla100 wants to merge 5 commits into from
Closed

[SPARK-31941][CORE] Replace SparkException to NoSuchElementException for applicationInfo in AppStatusStore #28768

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b2d33c
Add the code change to handle the SparkException
SaurabhChawla100 Jun 9, 2020
2b55c24
Add the code change to handle the SparkException
SaurabhChawla100 Jun 9, 2020
b75d168
Add the code change as per the review comments
SaurabhChawla100 Jun 9, 2020
99584f5
removed NoSuchElementException as SparkException is extending excepti…
SaurabhChawla100 Jun 9, 2020
e8769fb
throwing NoSuchElementException instead of SparkException
SaurabhChawla100 Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/ui/SparkUI.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package org.apache.spark.ui

import java.util.Date

import org.apache.spark.{SecurityManager, SparkConf, SparkContext}
import org.apache.spark.{SecurityManager, SparkConf, SparkContext, SparkException}
import org.apache.spark.internal.Logging
import org.apache.spark.internal.config.UI._
import org.apache.spark.scheduler._
Expand Down Expand Up @@ -86,7 +86,7 @@ private[spark] class SparkUI private (
.orElse(store.environmentInfo().systemProperties.toMap.get("user.name"))
.getOrElse("<unknown>")
} catch {
case _: NoSuchElementException => "<unknown>"
case _: SparkException => "<unknown>"

@sarutak sarutak Jun 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing SparkException with NoSuchElementException here?
That method threw NoSuchElementException before #28444 so I think it's better to keep the type of exception.
@HyukjinKwon suggested NoSuchElementException here but finally SparkException is used somehow.

@sarutak sarutak Jun 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried replacing SparkException with NoSuchElementException as I suggested and I can get the same error message as the screenshot shown here except the type of exception.
nosuchelement

@SaurabhChawla100 SaurabhChawla100 Jun 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure , I have replaced SparkException with NoSuchElementException. Please validate

}
}

Expand Down