[SPARK-31934][BUILD] Remove set -x from docker image tool#28759
Closed
holdenk wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-31934][BUILD] Remove set -x from docker image tool#28759holdenk wants to merge 1 commit intoapache:masterfrom
holdenk wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @dongjoon-hyun who brought this to my attention. |
dongjoon-hyun
approved these changes
Jun 8, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thanks, @holdenk .
Contributor
Author
|
Thanks, I'll merge this to master & branch-3.0 :) |
asfgit
pushed a commit
that referenced
this pull request
Jun 8, 2020
### What changes were proposed in this pull request? Remove `set -x` from the docker image tool. ### Why are the changes needed? The image tool prints out information that may confusing. ### Does this PR introduce _any_ user-facing change? Less information is displayed by the docker image tool. ### How was this patch tested? Ran docker image tool locally. Closes #28759 from holdenk/SPARK-31934-remove-extranious-info-from-the-docker-image-tool. Authored-by: Holden Karau <hkarau@apple.com> Signed-off-by: Holden Karau <hkarau@apple.com> (cherry picked from commit 06959eb) Signed-off-by: Holden Karau <hkarau@apple.com>
|
Test build #123651 has finished for PR 28759 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove
set -xfrom the docker image tool.Why are the changes needed?
The image tool prints out information that may confusing.
Does this PR introduce any user-facing change?
Less information is displayed by the docker image tool.
How was this patch tested?
Ran docker image tool locally.