[SPARK-31896][SQL] Handle am-pm timestamp parsing when hour is missing #28713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan @maropu @MaxGekk thanks |
|
Test build #123460 has finished for PR 28713 at commit
|
cloud-fan
reviewed
Jun 3, 2020
| accessor.get(ChronoField.HOUR_OF_AMPM) | ||
| } else if (accessor.isSupported(ChronoField.AMPM_OF_DAY) && | ||
| accessor.get(ChronoField.AMPM_OF_DAY) == 1) { | ||
| // When reach here, the `hour` part is missing, the pattern is always contains `a` and minute |
Contributor
There was a problem hiding this comment.
the hour part is missing and PM is specified
cloud-fan
approved these changes
Jun 3, 2020
|
Test build #123465 has finished for PR 28713 at commit
|
Member
Author
|
retest this please |
|
Test build #123468 has finished for PR 28713 at commit
|
|
Test build #123467 has finished for PR 28713 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jun 3, 2020
### What changes were proposed in this pull request?
This PR set the hour to 12/0 when the AMPM_OF_DAY field exists
### Why are the changes needed?
When the hour is absent but the am-pm is present, the time is incorrect for pm
### Does this PR introduce _any_ user-facing change?
yes, the change is user-facing but to change back to 2.4 to keep backward compatibility
e.g.
```sql
spark-sql> select to_timestamp('33:33 PM', 'mm:ss a');
1970-01-01 12:33:33
spark-sql> select to_timestamp('33:33 AM', 'mm:ss a');
1970-01-01 00:33:33
```
otherwise, the results are all `1970-01-01 00:33:33`
### How was this patch tested?
add unit tests
Closes #28713 from yaooqinn/SPARK-31896.
Authored-by: Kent Yao <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit afcc14c)
Signed-off-by: Wenchen Fan <[email protected]>
|
Test build #123481 has finished for PR 28713 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR set the hour to 12/0 when the AMPM_OF_DAY field exists
Why are the changes needed?
When the hour is absent but the am-pm is present, the time is incorrect for pm
Does this PR introduce any user-facing change?
yes, the change is user-facing but to change back to 2.4 to keep backward compatibility
e.g.
otherwise, the results are all
1970-01-01 00:33:33How was this patch tested?
add unit tests