[SPARK-31810][TEST] Fix AlterTableRecoverPartitions test using incorrect api to modify RDD_PARALLEL_LISTING_THRESHOLD #28634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharjain09
changed the title
Contributor
Author
Member
|
Jenkins test this please |
cloud-fan
reviewed
May 25, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
Show resolved
Hide resolved
cloud-fan
approved these changes
May 25, 2020
|
Test build #123085 has finished for PR 28634 at commit
|
HyukjinKwon
approved these changes
May 26, 2020
HyukjinKwon
pushed a commit
that referenced
this pull request
May 26, 2020
…ect api to modify RDD_PARALLEL_LISTING_THRESHOLD ### What changes were proposed in this pull request? Use the correct API in AlterTableRecoverPartition tests to modify the `RDD_PARALLEL_LISTING_THRESHOLD` conf. ### Why are the changes needed? The existing AlterTableRecoverPartitions test modify the RDD_PARALLEL_LISTING_THRESHOLD as a SQLConf using the withSQLConf API. But since, this is not a SQLConf, it is not overridden and so the test doesn't end up testing the required behaviour. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? This is UT Fix. UTs are still passing after the fix. Closes #28634 from prakharjain09/SPARK-31810-fix-recover-partitions. Authored-by: Prakhar Jain <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 452594f) Signed-off-by: HyukjinKwon <[email protected]>
Member
|
Merged to master and branch-3.0. |
Member
|
Seems it has a conflict against branch-2.4 but let me just don't port back as it's minor. Feel free to port back if anyone feels it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the correct API in AlterTableRecoverPartition tests to modify the
RDD_PARALLEL_LISTING_THRESHOLDconf.Why are the changes needed?
The existing AlterTableRecoverPartitions test modify the RDD_PARALLEL_LISTING_THRESHOLD as a SQLConf using the withSQLConf API. But since, this is not a SQLConf, it is not overridden and so the test doesn't end up testing the required behaviour.
Does this PR introduce any user-facing change?
No
How was this patch tested?
This is UT Fix. UTs are still passing after the fix.