[SPARK-31807][INFRA] Use python 3 style in release-build.sh #28632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhyun
changed the title
|
Test build #123065 has finished for PR 28632 at commit
|
HyukjinKwon
approved these changes
May 25, 2020
Member
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 25, 2020
### What changes were proposed in this pull request? This PR aims to use the style that is compatible with both python 2 and 3. ### Why are the changes needed? This will help python 3 migration. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual. Closes #28632 from williamhyun/use_python3_style. Authored-by: William Hyun <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 753636e) Signed-off-by: HyukjinKwon <[email protected]>
Member
Author
|
Thank you, @HyukjinKwon ! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 12, 2021
### What changes were proposed in this pull request? This PR aims to use the style that is compatible with both python 2 and 3. ### Why are the changes needed? This will help python 3 migration. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual. Closes #28632 from williamhyun/use_python3_style. Authored-by: William Hyun <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 753636e) Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 40e5de5) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Hi, @williamhyun and @HyukjinKwon . cc @viirya |
Member
|
Got it. Thanks @dongjoon-hyun |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use the style that is compatible with both python 2 and 3.
Why are the changes needed?
This will help python 3 migration.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual.