[SPARK-31612][SQL][DOCS][FOLLOW-UP] Fix a few issues in SQL ref #28608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #122970 has finished for PR 28608 at commit
|
Member
|
Thank you for your quick fix! |
Member
|
retest this please |
maropu
reviewed
May 22, 2020
| * [SQL Syntax](sql-ref-syntax.html) | ||
| * [DDL Statements](sql-ref-syntax-ddl.html) | ||
| * [DML Statements](sql-ref-syntax-ddl.html) | ||
| * [DML Statements](sql-ref-syntax-dml.html) |
maropu
approved these changes
May 22, 2020
|
Test build #123001 has finished for PR 28608 at commit
|
srowen
reviewed
May 22, 2020
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looks fine to me - they weren't in the previous order for a reason? alphabetizing seems fine if that's the standard.
Contributor
Author
|
@srowen This is for 3.0. Thanks! |
|
Test build #123006 has finished for PR 28608 at commit
|
maropu
pushed a commit
that referenced
this pull request
May 22, 2020
### What changes were proposed in this pull request? Fix a few issues in SQL Reference ### Why are the changes needed? To make SQL Reference look better ### Does this PR introduce _any_ user-facing change? Yes. before: <img width="189" alt="Screen Shot 2020-05-21 at 11 41 34 PM" src="https://user-images.githubusercontent.com/13592258/82639052-d0f38a80-9bbc-11ea-81a4-22def4ca5cc0.png"> after: <img width="195" alt="Screen Shot 2020-05-21 at 11 41 17 PM" src="https://user-images.githubusercontent.com/13592258/82639063-d5b83e80-9bbc-11ea-84d1-8361e6bee949.png"> before: <img width="763" alt="Screen Shot 2020-05-21 at 11 45 22 PM" src="https://user-images.githubusercontent.com/13592258/82639252-3e9fb680-9bbd-11ea-863c-e6a6c2f83a06.png"> after: <img width="724" alt="Screen Shot 2020-05-21 at 11 45 02 PM" src="https://user-images.githubusercontent.com/13592258/82639265-42cbd400-9bbd-11ea-8df2-fc5c255b84d3.png"> before: <img width="437" alt="Screen Shot 2020-05-21 at 11 41 57 PM" src="https://user-images.githubusercontent.com/13592258/82639072-db158900-9bbc-11ea-9963-731881cda4fd.png"> after <img width="347" alt="Screen Shot 2020-05-21 at 11 42 26 PM" src="https://user-images.githubusercontent.com/13592258/82639082-dfda3d00-9bbc-11ea-9bd2-f922cc91f175.png"> ### How was this patch tested? Manually build and check Closes #28608 from huaxingao/doc_fix. Authored-by: Huaxin Gao <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]> (cherry picked from commit ad9532a) Signed-off-by: Takeshi Yamamuro <[email protected]>
Member
|
Merged to master/3.0. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a few issues in SQL Reference
Why are the changes needed?
To make SQL Reference look better
Does this PR introduce any user-facing change?
Yes.
before:
after:
before:
after:
before:
after
How was this patch tested?
Manually build and check