[SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input #28604

maropu · 2020-05-22T00:08:08Z

What changes were proposed in this pull request?

This PR intends to add trivial tests to check #27024 has already been fixed in the master.

Closes #27024

Why are the changes needed?

For test coverage.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Added tests.

maropu · 2020-05-22T00:12:44Z

@cloud-fan @gengliangwang I've checked the proposal in #27024 again and I think it's been already fixed in the master. So, we could close SPARK-29854 now. Just in case, I opened this PR to add trivial tests to check that. But, closing this PR looks okay if not needed. Could you check this?

dongjoon-hyun · 2020-05-22T02:18:33Z

sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala


  setupTestData()

+  test("lpad/rpad should throw an exception for invalid length input if the ANSI mode enabled") {


Thank you, @maropu .
Can we add these new test coverage into string-functions.sql instead of SQLQuerySuite?

For ansi, you can create a new string-functions.sql under ansi directory.

dongjoon-hyun

+1, LGTM. Thank you, @maropu and @HyukjinKwon .

sql/core/src/test/resources/sql-tests/inputs/string-functions.sql

SparkQA · 2020-05-22T05:27:12Z

Test build #122953 has finished for PR 28604 at commit 4615923.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-05-22T07:05:02Z

Test build #122960 has finished for PR 28604 at commit fae1cf4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-05-22T07:05:02Z

Test build #122965 has finished for PR 28604 at commit ea9a527.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

cloud-fan · 2020-05-22T07:30:42Z

retest this please

SparkQA · 2020-05-22T11:55:40Z

Test build #122978 has finished for PR 28604 at commit ea9a527.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-05-22T12:11:55Z

retest this please

SparkQA · 2020-05-22T17:00:48Z

Test build #123000 has finished for PR 28604 at commit ea9a527.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

…tion for invalid length input ### What changes were proposed in this pull request? This PR intends to add trivial tests to check #27024 has already been fixed in the master. Closes #27024 ### Why are the changes needed? For test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added tests. Closes #28604 from maropu/SPARK-29854. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]> (cherry picked from commit 7ca73f0) Signed-off-by: Takeshi Yamamuro <[email protected]>

maropu · 2020-05-22T23:49:16Z

Thanks, all! Merged to master/3.0.

dongjoon-hyun · 2020-05-23T18:06:38Z

Hi, @maropu .
This seems to break branch-3.0. Could you make a follow-up with the regenerated output?

dongjoon-hyun · 2020-05-23T22:00:33Z

Since it's trivial, I regenerated it and made a hotfix followup commit to recover branch-3.0 Jenkins jobs.

maropu · 2020-05-23T22:07:05Z

Ah, sorry for that... Thanks for the update, anyway.

dongjoon-hyun · 2020-05-23T22:43:56Z

No problem~, @maropu .

maropu · 2020-05-23T22:47:44Z

I should be more careful when merging PRs into branch-3.0.

probot-autolabeler bot added the SQL label May 22, 2020

HyukjinKwon approved these changes May 22, 2020

View reviewed changes

dongjoon-hyun reviewed May 22, 2020

View reviewed changes

Fix

fae1cf4

maropu force-pushed the SPARK-29854 branch from 4615923 to fae1cf4 Compare May 22, 2020 02:59

dongjoon-hyun approved these changes May 22, 2020

View reviewed changes

cloud-fan reviewed May 22, 2020

View reviewed changes

sql/core/src/test/resources/sql-tests/inputs/string-functions.sql Outdated Show resolved Hide resolved

Udpate comment

ea9a527

maropu closed this in 7ca73f0 May 22, 2020

dongjoon-hyun mentioned this pull request May 23, 2020

[SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2 #28601

Closed

3 tasks


		setupTestData()

		test("lpad/rpad should throw an exception for invalid length input if the ANSI mode enabled") {

[SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input #28604

[SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input #28604

Uh oh!

Conversation

maropu commented May 22, 2020

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

maropu commented May 22, 2020

Uh oh!

dongjoon-hyun May 22, 2020

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun May 22, 2020

Choose a reason for hiding this comment

Uh oh!

maropu May 22, 2020

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SparkQA commented May 22, 2020

Uh oh!

SparkQA commented May 22, 2020

Uh oh!

SparkQA commented May 22, 2020

Uh oh!

cloud-fan commented May 22, 2020

Uh oh!

SparkQA commented May 22, 2020

Uh oh!

HyukjinKwon commented May 22, 2020

Uh oh!

SparkQA commented May 22, 2020

Uh oh!

maropu commented May 22, 2020

Uh oh!

dongjoon-hyun commented May 23, 2020

Uh oh!

dongjoon-hyun commented May 23, 2020

Uh oh!

maropu commented May 23, 2020

Uh oh!

dongjoon-hyun commented May 23, 2020

Uh oh!

maropu commented May 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants