[SPARK-31785][SQL][TESTS] Add a helper function to test all parquet readers #28598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@cloud-fan @mswit-databricks @adrian-ionescu Please, review this PR. |
cloud-fan
reviewed
May 21, 2020
| withParquetReaders("parquet-mr", "vectorized-oss")(code) | ||
| } | ||
|
|
||
| def withAllParquetReaders(code: => Unit): Unit = { |
Contributor
There was a problem hiding this comment.
can we simplify it?
def withAllParquetReaders(code: => Unit): Unit = {
// test the row-based reader
withSQLConf(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key -> "false")(code)
// test the vectorized reader
withSQLConf(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key -> "true")(code)
}
Member
There was a problem hiding this comment.
I would say code- > func but no big deal.
|
Test build #122930 has finished for PR 28598 at commit
|
cloud-fan
approved these changes
May 21, 2020
|
Test build #122936 has finished for PR 28598 at commit
|
HyukjinKwon
approved these changes
May 22, 2020
Member
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 22, 2020
…eaders ### What changes were proposed in this pull request? Add `withAllParquetReaders` to `ParquetTest`. The function allow to run a block of code for all available Parquet readers. ### Why are the changes needed? 1. It simplifies tests 2. Allow to test all parquet readers that could be available in projects based on Apache Spark. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By running affected test suites. Closes #28598 from MaxGekk/add-withAllParquetReaders. Authored-by: Max Gekk <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 60118a2) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
withAllParquetReaderstoParquetTest. The function allow to run a block of code for all available Parquet readers.Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running affected test suites.