[SPARK-31784][CORE][TEST] Fix test BarrierTaskContextSuite."share messages with allGather() call" #28596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #122920 has finished for PR 28596 at commit
|
Contributor
|
retest this please |
|
Test build #122949 has finished for PR 28596 at commit
|
Member
Author
|
retest this please |
| val messages = rdd2.collect().head | ||
| // All the task partitionIds are shared | ||
| for((x, i) <- messages.view.zipWithIndex) assert(x.toString == i.toString) | ||
| assert(messages === List("0", "1", "2", "3")) |
Contributor
There was a problem hiding this comment.
We'd better verify the whole rdd collect array, not only the head of result array?
|
Test build #122959 has finished for PR 28596 at commit
|
Contributor
|
LGTM |
jiangxb1987
pushed a commit
that referenced
this pull request
May 22, 2020
…sages with allGather() call"
### What changes were proposed in this pull request?
Change from `messages.toList.iterator` to `Iterator.single(messages.toList)`.
### Why are the changes needed?
In this test, the expected result of `rdd2.collect().head` should actually be `List("0", "1", "2", "3")` but is `"0"` now.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Updated test.
Thanks WeichenXu123 reported this problem.
Closes #28596 from Ngone51/fix_allgather_test.
Authored-by: yi.wu <[email protected]>
Signed-off-by: Xingbo Jiang <[email protected]>
(cherry picked from commit 83d0967)
Signed-off-by: Xingbo Jiang <[email protected]>
Contributor
|
Thanks, merged to master/3.0 ! |
|
Test build #122962 has finished for PR 28596 at commit
|
Member
Author
|
thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change from
messages.toList.iteratortoIterator.single(messages.toList).Why are the changes needed?
In this test, the expected result of
rdd2.collect().headshould actually beList("0", "1", "2", "3")but is"0"now.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Updated test.
Thanks @WeichenXu123 reported this problem.