[SPARK-30689][CORE][FOLLOW-UP] Add @since annotation for ResourceDiscoveryScriptPlugin/ResourceInformation#28591
Closed
Ngone51 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-30689][CORE][FOLLOW-UP] Add @since annotation for ResourceDiscoveryScriptPlugin/ResourceInformation#28591Ngone51 wants to merge 1 commit intoapache:masterfrom
Ngone51 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
I checked the related module and only found these two are missing the annotation. Please let me know if I missed someone else. Thanks! |
Ngone51
changed the title
|
Test build #122875 has finished for PR 28591 at commit
|
Member
Author
|
retest this please |
|
Test build #122881 has finished for PR 28591 at commit
|
tgravescs
approved these changes
May 20, 2020
Member
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 20, 2020
…overyScriptPlugin/ResourceInformation ### What changes were proposed in this pull request? Added `since 3.0.0` for `ResourceDiscoveryScriptPlugin` and `ResourceInformation`. ### Why are the changes needed? It's required for exposed APIs(#27689 (comment)). ### Does this PR introduce _any_ user-facing change? Yes, they can easily know when does Spark introduces the API. ### How was this patch tested? Pass Jenkins. Closes #28591 from Ngone51/followup-30689. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 26bc690) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added
@since 3.0.0forResourceDiscoveryScriptPluginandResourceInformation.Why are the changes needed?
It's required for exposed APIs(#27689 (comment)).
Does this PR introduce any user-facing change?
Yes, they can easily know when does Spark introduces the API.
How was this patch tested?
Pass Jenkins.