[WIP][SPARK-31579][SQL] Floor div to div #28573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
Hi, @Sudhar287. Is this PR still WIP? I set |
Contributor
Author
|
Thanks for the response @maropu! This is not a work in progress. |
Member
|
Ah I see. But, I think you don't need to open a new PR for that purpose. Could you close this? |
Contributor
Author
|
Okay. But how else should I share my findings? My idea was to simply update this PR once the proof is validated... |
Member
|
If you want to discuss this topic, I think you should do in the JIRA side by showing your PoF patch in your local (forked) repository. |
Contributor
Author
|
Right. Got it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a proof-of-concept PR for replacing
floorDivinlocalRebaseGregorianToJulianDays()to onlydivso that performance can be improved.For this, we need to ensure that
utcCal.getTimeInMillis % MILLIS_PER_DAY == 0If my method to verify the above is correct, then I will update this PR to simply remove floorDiv and add div.
For SPARK-31579 @MaxGekk
Why are the changes needed?
Better and faster performance
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit testing.