-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-4003] [SQL] add 3 types for java SQL context #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
QA tests have started for PR 2850 at commit
|
|
QA tests have finished for PR 2850 at commit
|
|
Test PASSed. |
|
Can you add some tests too? |
|
QA tests have started for PR 2850 at commit
|
|
QA tests have finished for PR 2850 at commit
|
|
Test FAILed. |
|
retest this please. |
|
QA tests have started for PR 2850 at commit
|
|
QA tests have finished for PR 2850 at commit
|
|
Test PASSed. |
|
Good catch! LGTM, thanks. |
|
Thanks for working on this! In order for the BigDecimals to work we are going to need to do some conversions as well. This is because the expected internal representation of BigDecimal is the scala class, not the java one. Consider the following test case: assert(
javaSqlCtx.sql("SELECT bigDecimalField + bigDecimalField FROM allTypes").collect.head.row ===
Seq(new java.math.BigDecimal(0)))Which will throw I think we'll need to do something similar to convertToCatalyst but for Java. |
|
@adrian-wang any chance you will have time to update this before the 1.2 code freeze this Friday? |
|
Sure, I'll deal with that soon. |
|
Test build #22449 has started for PR 2850 at commit
|
|
Test build #22449 has finished for PR 2850 at commit
|
|
Test PASSed. |
In JavaSqlContext, we need to let java program use big decimal, timestamp, date types.