Skip to content

[SPARK-31593][SS] Remove unnecessary streaming query progress update #28391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uncleGen wants to merge 4 commits into from
Closed

[SPARK-31593][SS] Remove unnecessary streaming query progress update #28391

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4201180
Remove unnecessary streaming query progress update
uncleGen Apr 28, 2020
4a55b25
update ut
uncleGen May 9, 2020
c3db6cf
fix codestyle
uncleGen May 9, 2020
8479341
fix comments
uncleGen Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ trait ProgressReporter extends Logging {

if (hasExecuted) {
// Reset noDataEventTimestamp if we processed any data
lastNoExecutionProgressEventTime = Long.MinValue
lastNoExecutionProgressEventTime = triggerClock.getTimeMillis()
Copy link
Contributor Author

@uncleGen uncleGen Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reset "lastNoExecutionProgressEventTime =Long.MinValue", it will make "now - noDataProgressEventInterval >= lastNoExecutionProgressEventTime" always true when there is no new data. Then progress reporter will report an empty progress.

updateProgress(newProgress)
} else {
val now = triggerClock.getTimeMillis()
Expand Down