[SPARK-31564][TESTS] Fix flaky AllExecutionsPageSuite for checking 1970 #28344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
srowen
approved these changes
Apr 25, 2020
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Makes sense, pending tests. This should backport all the way to 2.4?
Member
Author
|
thanks @srowen, SPARK-27125 seems only to be fixed in 3.0.0 via #24052 |
Member
|
OK so needs to go into 3.0 |
dongjoon-hyun
approved these changes
Apr 25, 2020
HyukjinKwon
approved these changes
Apr 25, 2020
|
Test build #121807 has finished for PR 28344 at commit
|
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 25, 2020
### What changes were proposed in this pull request? Fix flakiness by checking `1970/01/01` instead of `1970`. The test was added by SPARK-27125 for 3.0.0. ### Why are the changes needed? the `org.apache.spark.sql.execution.ui.AllExecutionsPageSuite.SPARK-27019:correctly display SQL page when event reordering happens` test is flaky for just checking the `html` content not containing 1970. I will add a ticket to check and fix that. In the specific failure https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121799/testReport, it failed because the `html` ``` ... <td sorttable_customkey="1587806019707"> ... ``` contained `1970`. ### Does this PR introduce any user-facing change? no ### How was this patch tested? passing jenkins Closes #28344 from yaooqinn/SPARK-31564. Authored-by: Kent Yao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7959808) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Thank you all. Merged to master/3.0. |
Member
Author
|
Thanks for merging @dongjoon-hyun. BTW, 2.4 should be 3.0. |
Member
|
Right. Thank you. I fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flakiness by checking
1970/01/01instead of1970.The test was added by SPARK-27125 for 3.0.0.
Why are the changes needed?
the
org.apache.spark.sql.execution.ui.AllExecutionsPageSuite.SPARK-27019:correctly display SQL page when event reordering happenstest is flaky for just checking thehtmlcontent not containing 1970. I will add a ticket to check and fix that.In the specific failure https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121799/testReport, it failed because the
htmlcontained
1970.Does this PR introduce any user-facing change?
no
How was this patch tested?
passing jenkins