Skip to content

Conversation

@gaborgsomogyi
Copy link
Contributor

What changes were proposed in this pull request?

This is a followup PR discussed here.

Why are the changes needed?

It would be good to re-enable DB2IntegrationSuite and upgrade the docker image inside to use the latest.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing docker integration tests.

"LICENSE" -> "accept"
"LICENSE" -> "accept",
"DBNAME" -> "foo",
"ARCHIVE_LOGS" -> "false",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARCHIVE_LOGS and AUTOCONFIG is needed because it triggers a server side restart (which made the suite fail all the time). Please see the following code snippet extracted from the docker image:

configure_db()
{
   dbname=$1

   if [ ${ARCHIVE_LOGS?} = "true" -o "${HADR_ENABLED?}" = "true" ]; then
       # Enabling log archiving does not exit with a zero because of SQL1363W
       enable_log_archiving ${dbname?}
       restart_db2

       if ! back_up ${dbname?}; then
          echo "(!) Failed to back up ${dbname?} database"
       fi
   else
       echo "(*) Log archiving will not be configured as ARCHIVE_LOGS has been set to false. "
   fi
   
   if [ ${AUTOCONFIG?} = "true" -o "${HADR_ENABLED?}" = "true" ]; then
      if ! run_autoconfig ${dbname?}; then
         echo "(!) Failed to automatically configure ${dbname?} database"
      fi
   else
      echo "(*) Instance and database will not be auto configured. AUTOCONFIG has been set to false. "
   fi

   if ! configure_text_search ${dbname?}; then
      echo "(!) Failed to configure ${dbname?} database for text search"
   fi
}

I've applied the same in the kerberos suite because until now it was only timing luck that it's not failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@gaborgsomogyi
Copy link
Contributor Author

cc @HeartSaVioR

@SparkQA
Copy link

SparkQA commented Apr 24, 2020

Test build #121747 has finished for PR 28325 at commit 7fbc27b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gaborgsomogyi
Copy link
Contributor Author

retest this, please

@SparkQA
Copy link

SparkQA commented Apr 24, 2020

Test build #121760 has finished for PR 28325 at commit 7fbc27b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gaborgsomogyi
Copy link
Contributor Author

retest this, please

@dongjoon-hyun
Copy link
Member

Thank you, @gaborgsomogyi .

)
override val usesIpc = false
override val jdbcPort: Int = 50000
override val privileged = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, why privileged is required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docker requires priviliged run. Please see the how to use section of the docker image.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I checked the doc. It's at least required during re-mount the volumes even we don't provide a volume.

@SparkQA
Copy link

SparkQA commented Apr 24, 2020

Test build #121771 has finished for PR 28325 at commit 7fbc27b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you. I verified this locally.

DB2IntegrationSuite:
...
- Basic test
- Numeric types
- Date types
- String types
- Basic write test
- query JDBC option
...

@dongjoon-hyun
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants