Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 23, 2020

What changes were proposed in this pull request?

This PR aims to upgrade Genjavadoc to 0.16.

Why are the changes needed?

Although we skipped Scala 2.12.11, this brings 2.12.11 official support and better 2.12.12 compatibility.

Does this PR introduce any user-facing change?

No. (The generated doc is the same)

How was this patch tested?

Build with 0.15 and 0.16.

$ SKIP_PYTHONDOC=1 SKIP_RDOC=1 SKIP_SQLDOC=1 jekyll build

Compare the result. The generated doc is identical.

$ diff -r _site_0.15 _site_0.16 | grep -v '^diff -r' | grep -v 'Generated by javadoc' | sort | uniq
---
5c5

@dongjoon-hyun
Copy link
Member Author

cc @sarutak

@sarutak
Copy link
Member

sarutak commented Apr 24, 2020

I'll take at this.

@SparkQA
Copy link

SparkQA commented Apr 24, 2020

Test build #121704 has finished for PR 28321 at commit 93c8f09.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Let me leave it to @sarutak

@sarutak
Copy link
Member

sarutak commented Apr 24, 2020

LGTM. I also checked on my laptop.
Merging this into master. Thanks @dongjoon-hyun and @HyukjinKwon !

@sarutak sarutak closed this in 6180028 Apr 24, 2020
@dongjoon-hyun
Copy link
Member Author

Thank you, @sarutak and @HyukjinKwon !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-31547 branch April 24, 2020 04:21
@sarutak
Copy link
Member

sarutak commented Apr 24, 2020

@HyukjinKwon Thanks for closing the ticket in JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants