Skip to content

[SPARK-31465][SQL][DOCS][FOLLOW-UP] Document Literal in SQL Reference#28306

Closed
huaxingao wants to merge 1 commit intoapache:masterfrom
huaxingao:literal-folllowup
Closed

[SPARK-31465][SQL][DOCS][FOLLOW-UP] Document Literal in SQL Reference#28306
huaxingao wants to merge 1 commit intoapache:masterfrom
huaxingao:literal-folllowup

Conversation

@huaxingao
Copy link
Contributor

@huaxingao huaxingao commented Apr 23, 2020

What changes were proposed in this pull request?

Need to address a few more comments

Why are the changes needed?

Fix a few problems

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

Manually build and check

@huaxingao
Copy link
Contributor Author

@cloud-fan @maropu
Sorry, your guys are too fast for me :)

@SparkQA
Copy link

SparkQA commented Apr 23, 2020

Test build #121651 has finished for PR 28306 at commit 9ab90f2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Apr 23, 2020

Oops, I see. LGTM.

@maropu
Copy link
Member

maropu commented Apr 23, 2020

Since this fix is not related to the running tests, I'll merge it. Thanks.

@maropu maropu closed this in f543d6a Apr 23, 2020
maropu pushed a commit that referenced this pull request Apr 23, 2020
### What changes were proposed in this pull request?
Need to address a few more comments

### Why are the changes needed?
Fix a few problems

### Does this PR introduce any user-facing change?
Yes

### How was this patch tested?
Manually build and check

Closes #28306 from huaxingao/literal-folllowup.

Authored-by: Huaxin Gao <huaxing@us.ibm.com>
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
(cherry picked from commit f543d6a)
Signed-off-by: Takeshi Yamamuro <yamamuro@apache.org>
@maropu
Copy link
Member

maropu commented Apr 23, 2020

Merged to master/3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants