[SPARK-18886][CORE][TESTS][FOLLOWUP] Fix a test failure due to InvalidUseOfMatchersException #28174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
commented
Apr 10, 2020
| // To avoid allocating any resources immediately after releasing the resource from the task to | ||
| // make sure that `availableAddrs` below won't change | ||
| when(ts.resourceOffers(any[IndexedSeq[WorkerOffer]])).thenReturn(Seq.empty) | ||
| when(ts.resourceOffers(any[IndexedSeq[WorkerOffer]], any[Boolean])).thenReturn(Seq.empty) |
Member
Author
There was a problem hiding this comment.
This is added recently by another PR.
Member
There was a problem hiding this comment.
Does it just affect master? OK in any event if it fixes a test.
Member
Author
|
cc @bmarcott , @cloud-fan , @tgravescs |
Member
Author
|
Also, cc @srowen |
HyukjinKwon
approved these changes
Apr 10, 2020
Member
|
I am going to merge unblock the PR builders. |
Member
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 10, 2020
…dUseOfMatchersException ### What changes were proposed in this pull request? This fixes one UT failure. ``` [info] - extra resources from executor *** FAILED *** (218 milliseconds) [info] org.mockito.exceptions.misusing.InvalidUseOfMatchersException: Invalid use of argument matchers! [info] 0 matchers expected, 1 recorded: ``` ### Why are the changes needed? The original PR was merged with an outdated Jenkins result (7 days before the merging). ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins or manually do the following. ``` $ build/sbt "core/testOnly *.CoarseGrainedSchedulerBackendSuite" ``` Closes #28174 from dongjoon-hyun/SPARK-18886. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit c6ea693) Signed-off-by: HyukjinKwon <[email protected]>
Member
Author
|
Thank you for reviewing and merging, @HyukjinKwon ! |
|
Test build #121052 has finished for PR 28174 at commit
|
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…dUseOfMatchersException ### What changes were proposed in this pull request? This fixes one UT failure. ``` [info] - extra resources from executor *** FAILED *** (218 milliseconds) [info] org.mockito.exceptions.misusing.InvalidUseOfMatchersException: Invalid use of argument matchers! [info] 0 matchers expected, 1 recorded: ``` ### Why are the changes needed? The original PR was merged with an outdated Jenkins result (7 days before the merging). ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins or manually do the following. ``` $ build/sbt "core/testOnly *.CoarseGrainedSchedulerBackendSuite" ``` Closes apache#28174 from dongjoon-hyun/SPARK-18886. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fixes one UT failure.
Why are the changes needed?
The original PR was merged with an outdated Jenkins result (7 days before the merging).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins or manually do the following.